Rollup of 12 pull requests #147598
Closed
Rollup of 12 pull requests #147598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to rust-lang#137400. The current macro is incredibly complicated and introduces subtle bugs like calling the `extend_one` of the individual collections in backwards order. This PR drastically simplifies the macro by removing recursion and moving the specialization out of the macro. It also fixes the ordering issue described above (I've stolen the test of the new behaviour from rust-lang#137400). Additionally, the 1-tuple is now special-cased to allow taking advantage of the well-optimized `Extend` implementations of the individual collection.
ordering of side-effects to `coretest`.
Most new API has an associated ACP that is useful to reference, but it doesn't appear anywhere on the template for new tracking issues. Update this template to include a link to the ACP.
It's possible for targets to only support `core` and not `alloc`. Instead of building alloc unconditionally, pass a list of crates to build into `std_cargo`, and only pass `-p alloc` if the list of crates wasn't already filtered to a subset. The original use case was to reuse `std_cargo` for a rustc_driver that doesn't emit metadata. But this seems like a reasonable change regardless.
Keeping it up-to-date with upstream for the latest bug fixes and such related to wasm-tools-implemented internals.
Since `LLVMRustContextCreate` can easily be replaced with a call to `LLVMContextCreate` and `LLVMContextSetDiscardValueNames`.
Currently x.py help (or x.py --help) builds bootstrap binary everytime, but it delays printing help. This change saves the current top level help text into a file. x.py help prints the file and doesn't touch bootstrap binary. x.py test bootstrap checks if the file is up to date. Note that subcommand level helps (e.g., x.py check --help) aren't saved.
* Adds armv7a-none-eabihf (rust-lang#146522) * Adds armv8r-none-eabihf (rust-lang#146520) * Drops armeb*-none-* (rust-lang#146523)
…crum core: simplify `Extend` for tuples This is an alternative to rust-lang#137400. The current macro is incredibly complicated and introduces subtle bugs like calling the `extend_one` of the individual collections in backwards order. This PR drastically simplifies the macro by removing recursion and moving the specialization out of the macro. It also fixes the ordering issue described above (I've stolen the test of the new behaviour from rust-lang#137400). Additionally, the 1-tuple is now special-cased to allow taking advantage of the well-optimized `Extend` implementations of the individual collection.
…lacrum Save x.py's help text for saving output time Fix rust-lang#141903 Currently x.py help (--help) builds bootstrap binary everytime, so it takes some seconds to print help. This PR does: - Saves current help text into a file (x.py run generate-help) - Changes bootstrap.py to print the help in the saved file and to exit without touching bootstrap binary - Modifies x.py test bootstrap to check if the help file is up-to-date
Don't unconditionally build alloc for `no-std` targets It's possible for targets to only support `core` and not `alloc`. Instead of building alloc unconditionally, pass a list of crates to build into `std_cargo`, and only pass `-p alloc` if the list of crates wasn't already filtered to a subset. The original use case was to reuse `std_cargo` for a rustc_driver that doesn't emit metadata. But this seems like a reasonable change regardless.
…k-Simulacrum [DebugInfo] Improve formatting of MSVC enum struct variants More robust handling mirroring the `TupleSummaryProvider` function before: <img width="1168" height="28" alt="image" src="https://github.com/user-attachments/assets/994f0884-55c2-4d3d-b1b2-97df17f0c9f0" /> after: <img width="813" height="31" alt="image" src="https://github.com/user-attachments/assets/8ad3dfa0-3aa7-42a9-bf50-6f5eaf0365aa" /> This shouldn't affect any tests as we don't run debuginfo tests for MSVC afaik
…-Simulacrum Add an ACP list item to the library tracking issue template Most new API has an associated ACP that is useful to reference, but it doesn't appear anywhere on the template for new tracking issues. Update this template to include a link to the ACP.
…=Mark-Simulacrum Explain not existed key in BTreeMap::split_off Fixes rust-lang#147174 r? libs
Extract most code from `define_feedable!` This PR extracts most of the non-trivial code from the `define_feedable!` macro (which defines the `TyCtxtFeed::$query` methods), and moves it to a helper function `query_feed_inner` written in ordinary non-macro code. Doing so should make that code easier to read and modify, because it now gets proper IDE support and has explicit trait bounds. --- There should be no change in compiler behaviour. I've structured the commits so that the actual extraction part is mostly just whitespace changes, making it easier to review individually with whitespace changes hidden.
…-ld, r=Mark-Simulacrum Update wasm-component-ld to 0.5.18 Keeping it up-to-date with upstream for the latest bug fixes and such related to wasm-tools-implemented internals.
…joboet Fix documentation of Instant::now on mac It is `CLOCK_UPTIME_RAW` on Apple. https://github.com/rust-lang/rust/blob/b6f0945e4681bc4d2faa7c22c5f61dc36abf7dd2/library/std/src/sys/pal/unix/time.rs#L260-L264
…ottmcm Change int-to-ptr transmute lowering back to inttoptr This is a revert of rust-lang#121282, but with a regression test to cover the reported miscompile in rust-lang#147265 that was caused by the way the code here combines with rust-lang#138759.
…ate, r=Zalathar Replace `LLVMRustContextCreate` with normal LLVM-C API calls Since `LLVMRustContextCreate` can easily be replaced with a call to `LLVMContextCreate` and `LLVMContextSetDiscardValueNames`. Work towards rust-lang#46437
…ets, r=Mark-Simulacrum Adjust the Arm targets in CI to reflect latest changes * Adds build of `armv7a-none-eabihf` (rust-lang#146522) * Adds build of `armv8r-none-eabihf` (rust-lang#146520) * Drops build of `armeb*-none-*` (rust-lang#146523) I wasn't sure why `armv7a-none-eabihf` was missing from the build-manifest program, but `armv8r-none-eabihf` was there, as they were both Tier 3 targets up until very recently. So, I added it, but that might be wrong.
rustbot
added
A-CI
rustbot
added
A-testsuite
|
Rollup of everything. @bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 12, 2025
Rollup of 12 pull requests Successful merges: - #138799 (core: simplify `Extend` for tuples) - #146692 (Save x.py's help text for saving output time) - #147168 (Don't unconditionally build alloc for `no-std` targets) - #147178 ([DebugInfo] Improve formatting of MSVC enum struct variants) - #147240 (Add an ACP list item to the library tracking issue template) - #147246 (Explain not existed key in BTreeMap::split_off) - #147393 (Extract most code from `define_feedable!`) - #147495 (Update wasm-component-ld to 0.5.18) - #147503 (Fix documentation of Instant::now on mac) - #147541 (Change int-to-ptr transmute lowering back to inttoptr) - #147549 (Replace `LLVMRustContextCreate` with normal LLVM-C API calls) - #147596 (Adjust the Arm targets in CI to reflect latest changes) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This was referenced Oct 12, 2025
|
For now I'll assume that #147596 was the cause of failure, while running some try jobs to double-check. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Extendfor tuples #138799 (core: simplifyExtendfor tuples)no-stdtargets #147168 (Don't unconditionally build alloc forno-stdtargets)define_feedable!#147393 (Extract most code fromdefine_feedable!)LLVMRustContextCreatewith normal LLVM-C API calls #147549 (ReplaceLLVMRustContextCreatewith normal LLVM-C API calls)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup